Repeated Buddy Requests and the <permissionTimeOut>-Se

[amenthes]

Hi there,

Today we found a behaviour, that might not be a bug, but it is still confusing:

Suppose you have two users: A and B.
A adds B as a buddy.
B Accepts.
-> Everything is fine.

For some reason A or B remove the other one from their list (perhaps accidentally).
A tries to add B again.
If this retry is happening during the permissionTimeOut, it will be filtered.

Code: Select all

16:19:43.951 - [ INFO ] > Asking buddy permission. Sender: amenthes, Target:it.gotoandplay.smartfoxserver.data.User@1908ba7
  // here the request was accepted.
  // here the one of the users removed the other from the buddylist
16:20:03.175 - [ INFO ] > Add buddy request rejected. Sender: amenthes, Target: amen, Reason: An identical request already exist!
16:25:46.859 - [ INFO ] > Add buddy request rejected. Sender: amenthes, Target: amen, Reason: An identical request already exist!

in my application, the timeout is set to 10 minutes, but i think in case of a successful friendship-request, the request should be cleared immediately (so that in the accidental use-case described above, the second request can happen immediately afterwards).

Reproducable with Smartfoxserver 1.6.5.02 - didn't have the time to upgrade yet.

[Lapo]

Yes, it is not exactly a bug but it can anyways improved.