room list update - new room vars overwritten with old ones

[fsol]

Hi,

I'm using AS3 client 1.6.1.

My lobby does some stuff with Room variables, so I've set the 'roomListVars' attribute to true on the zone config.

I noticed that the room vars weren't updating correctly when using getRoomList(), even though the debug XML looks fine. Looking through the code, it seems that if an old room exist, it overwrites the new one's variables:

SysHandler (v.1.3.0) line 176:

Code: Select all

// Handle Room Variables
				if (roomXml.vars.toString().length > 0)
				{
					populateVariables(room.getVariables(), roomXml)			
				}	
				
				/*
				* Merge with current room list data, to avoid destroying previous data
				* @since 1.6.0
				*/
				var oldRoom:Room = roomList[roomId]
				if (oldRoom != null)
				{
					room.setVariables( oldRoom.getVariables() )
					room.setUserList( oldRoom.getUserList() )
				}
				
				roomList[roomId] = room	

in particular, this line:

Code: Select all

room.setVariables( oldRoom.getVariables() )

Shouldn't this merge / update variables individually rather than just overwrite the whole list?

[Lapo]

This is already done in the latest 1.6.8 patch.

[fsol]

Hi -

I'm using the latest patch (1.6.8), which contains these AS3 client classes:

SmartFoxClient 1.6.1

SysHandler 1.3.0

Are these the latest versions?

Cheers
f

[Lapo]

Hi, your version number is correct.
As regards your specific question: the code is correct because it affects only the Rooms that the User is currently joined in, preserving the current state of variables and the User List.

The getRoomList() response from server by default does not contain any info about RoomVariables, unless you specify in your config to also send the RoomVars.

In this case, yes you could have a problem there.
Is this your setup? If so a quick workaround is to comment the line of code you have outlined.

[fsol]

Hi,

Yes, I'm using roomListVars="true" in the zone config file.

Cheers
f